Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use runtime classloader as TCCL during application close #7305

Merged
merged 1 commit into from Feb 20, 2020

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Feb 20, 2020

Fixes #7161.

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 20, 2020

I know this PR fixes the linked issue. What I really truly absolutely don't know is if it's the correct thing to do :-)

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 20, 2020

Hmm, the failing test says:

com.microsoft.sqlserver.jdbc.SQLServerException: The TCP/IP connection to the host localhost, port 1433 has failed. Error: "Connection refused (Connection refused). Verify the connection properties. Make sure that an instance of SQL Server is running on the host and accepting TCP/IP connections at the port. Make sure that TCP connections to the port are not blocked by a firewall.".

It seems unlikely to me that this could be caused by the change in this PR. Looks more like a flaky test. Is there a way to rerun...?

@geoand geoand merged commit 46d0226 into quarkusio:master Feb 20, 2020
@Ladicek Ladicek deleted the tccl-during-close branch February 20, 2020 16:26
@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 20, 2020

Thanks @geoand! Should this be in a milestone or something like that? (I don't know, and don't have permissions to set it anyway :-) ) Just wondering.

@geoand geoand added this to the 1.3.0 milestone Feb 20, 2020
@geoand
Copy link
Contributor

geoand commented Feb 20, 2020

Ah yes, my bad, I should have added it! Thanks for pointing that out.

Now I'll go and check the other PRs that I merged :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants