fix(docs): make sure that mapped properties are sorted properly #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the config phase comparator even for mapped properties to make sure that config items in a Map are sorted in correct ordering - build time items first and runtime items at the end Fixes quarkusio#7781
|
@gsmet can you try this? I checked the output and it should be okay but would need a second eye. |
|
Thanks @gsmet for taking a look and for the review. |
|
Thanks for the fix. I'll wait for CI to be extra sure and merge. |
machi1990
deleted the
docs/sort-mapped-runtime-config-items-at-the-end-of-config-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the config phase comparator even for mapped properties to make sure that config items in a Map
are sorted in correct ordering - build time items first and runtime items at the end
Fixes #7781