Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide rest-client-<serialization> extensions #8089

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 23, 2020

Relates to: #8063

@gsmet gsmet requested a review from geoand March 23, 2020 18:34
@boring-cyborg boring-cyborg bot added area/core area/dependencies Pull requests that update a dependency file labels Mar 23, 2020
@geoand
Copy link
Contributor

geoand commented Mar 24, 2020

I also tested the rest-client-quickstart with the quarkus-rest-client-jsonb and it worked like a charm! Furthermore I also checked in an application that only used Vert.x for the server part and quarkus-rest-client-jackson for the client and again everything worked great.

The only thing I am not excited about is that for the tests in the new modules, the meaningful assertions are done in the application code, making it hard to see the real error if a test fails.
But that shouldn't be a problem since the applications are very small, so nailing down the cause of any future test failure should be easy.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful for users, thanks!

@gsmet gsmet added this to the 1.4.0 milestone Mar 24, 2020
@gsmet gsmet marked this pull request as ready for review March 24, 2020 10:50
@gsmet gsmet merged commit 1287f8a into quarkusio:master Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants