Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed aesh cli to inherit from the build parent fixes #783 #809

Merged
merged 2 commits into from
Feb 8, 2019
Merged

changed aesh cli to inherit from the build parent fixes #783 #809

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7604d8c
changed aesh cli to inherit from the build parent fixes #783
stalep Feb 8, 2019
25898fa
moved aesh dependencies to build-parent
stalep Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions cli/aesh/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,20 @@
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<parent>
<artifactId>shamrock-build-parent</artifactId>
<groupId>org.jboss.shamrock</groupId>
<version>1.0.0.Alpha1-SNAPSHOT</version>
<relativePath>../../build-parent/pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>

<groupId>org.jboss.shamrock</groupId>
<artifactId>shamrock-cli</artifactId>
<name>Shamrock - CLI Native Tool</name>
<version>1.0.0.Alpha1-SNAPSHOT</version>

<properties>
<test.level>INFO</test.level>

<aesh.version>1.11</aesh.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be in build-parent/pom.xml, shouldn't it?

And you should add it to the dependencyManagement.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup i agree! - thanks for the comment, updated the pr now!

<!-- maven-compiler-plugin -->
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>1.8</maven.compiler.source>
Expand All @@ -42,7 +46,7 @@
<dependency>
<groupId>org.aesh</groupId>
<artifactId>aesh</artifactId>
<version>1.11</version>
<version>${aesh.version}</version>
</dependency>

<dependency>
Expand Down