Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that RunnerClassloader can read directory resources #9514

Merged
merged 1 commit into from May 22, 2020
Merged

Ensure that RunnerClassloader can read directory resources #9514

merged 1 commit into from May 22, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented May 21, 2020

Fixes: #9513

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels May 21, 2020
@geoand
Copy link
Contributor Author

geoand commented May 21, 2020 •
edited

As you can imagine, the test was a lot harder to write than the fix :)

PR is in draft until CI finishes on my fork. I did run all the maven integration tests locally however and they passed

@geoand geoand marked this pull request as ready for review May 21, 2020 14:41
@stuartwdouglas stuartwdouglas added this to the 1.6.0 milestone May 22, 2020
@stuartwdouglas stuartwdouglas merged commit 3f74cdc into quarkusio:master May 22, 2020
@geoand geoand deleted the #9513 branch May 22, 2020 06:06
@gsmet gsmet modified the milestones: 1.6.0 - master, 1.5.0.Final May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
1.5.0.Final
Development

Successfully merging this pull request may close these issues.

Flyway didn't works using fast-jar
3 participants
@geoand @stuartwdouglas @gsmet