Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to v0.6 of the embedded-nal #15

Merged
merged 2 commits into from
May 27, 2021
Merged

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented May 27, 2021

This PR resolves #11 by updating to embedded-nal v0.6 (the current release).

This PR also:

  • Updates the repository to utilize const-generics
  • Removes all usage of RefCell

Testing

This branch (along with the minimq update to the embedded-nal) were run on Stabilizer. It was confirmed that Stabilizer acquired an IP via DHCP and published MQTT telemetry as expected.

@ryan-summers ryan-summers changed the title Updating to 0.6 of the embedded-nal Updating to v0.6 of the embedded-nal May 27, 2021
@ryan-summers ryan-summers requested a review from jordens May 27, 2021 11:41
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements. Looks good otherwise!

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@ryan-summers ryan-summers requested a review from jordens May 27, 2021 12:52
@ryan-summers ryan-summers merged commit b74d93a into main May 27, 2021
@ryan-summers ryan-summers deleted the feature/nal-update branch May 27, 2021 13:14
bors bot added a commit to quartiq/stabilizer that referenced this pull request May 27, 2021
370: Updating dependencies + embedded-nal r=ryan-summers a=ryan-summers

This PR updates Stabilizer to utilize updated `smoltcp-nal` and `minimq`.

This is pending the following PRs:
* [x] quartiq/smoltcp-nal#15
* [x] quartiq/minimq#45

This is in preparation for further improvements to the smoltcp-nal to facilitate livestreaming.

Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
bors bot added a commit to quartiq/stabilizer that referenced this pull request May 27, 2021
370: Updating dependencies + embedded-nal r=ryan-summers a=ryan-summers

This PR updates Stabilizer to utilize updated `smoltcp-nal` and `minimq`.

This is pending the following PRs:
* [x] quartiq/smoltcp-nal#15
* [x] quartiq/minimq#45

This is in preparation for further improvements to the smoltcp-nal to facilitate livestreaming.

Co-authored-by: Ryan Summers <ryan.summers@vertigo-designs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embedded_nal 0.4.0 support
2 participants