Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrator hold #70

Closed
jordens opened this issue Dec 3, 2019 · 0 comments · Fixed by #338
Closed

integrator hold #70

jordens opened this issue Dec 3, 2019 · 0 comments · Fixed by #338
Labels
enhancement New feature or request

Comments

@jordens
Copy link
Member

jordens commented Dec 3, 2019

During process(), if a digital input is high, do not update the IIRs.

  • Strictly speaking the correct implementation is to update the y (output) delay line with the unchanged previous output, but keep updating the x delay line with new input. This seems to be semantically best implemented by updating with a "unity-gain-feedback-iir" instead of the usual "active" one. As a first approximation to this, just not calling iir.update(..) is fine.
  • Would be nice to have the pin functionality configurable or at least not conflicting. I.e. not have code conflict between the use of DIN0 as ref input for timestamping and the use as a GPIO (to be read explicitly). I.e. be able to use either functionality for DIN0 in different binaries. Conveniently, the DI0/1 signals each are available on two pins. This is easy then.
  • This integrator hold flag should be and-ed with a flag integrator_hold_chA_dinB_en and or-ed with a flag integrator_hold_chA from the network-accessible settings.

Note: DINs should have pulldowns. sinara-hw/Stabilizer#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant