Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About page behaviour changed between 1.4.533 and 1.4.534 #8544

Closed
mcanouil opened this issue Feb 1, 2024 · 3 comments · Fixed by #8585
Closed

About page behaviour changed between 1.4.533 and 1.4.534 #8544

mcanouil opened this issue Feb 1, 2024 · 3 comments · Fixed by #8585
Assignees
@dragonstyle @mcanouil
Labels
bug Something isn't working websites Issues creating websites
Milestone
v1.5

Comments

@mcanouil
Copy link
Collaborator

mcanouil commented Feb 1, 2024 •
edited

It appears between 1.4.533 and 1.4.534, the elements of "about" is no longer respecting the position defined by the use of the id of the about element.
Moving the fenced div around has no effect.

Reproducible example at: https://github.com/mcanouil/quarto-issues-experiments/tree/main/quarto-cli-8544

v1.4.533 v1.4.534
image image

If you put the whole "content" in a fenced div, everything stays together but still on top of the about element.

image
@mcanouil mcanouil added bug Something isn't working websites Issues creating websites triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. labels Feb 1, 2024
@mcanouil mcanouil added this to the v1.5 milestone Feb 1, 2024
@mcanouil
Copy link
Collaborator Author

mcanouil commented Feb 1, 2024

Side note: the "content" is not inside the fenced divs on purpose.

Aim/before if inside the div
image image

This was referenced Feb 1, 2024
Merged
Closed
dragonstyle added a commit that referenced this issue Feb 4, 2024
@dragonstyle
Website About - fix layout
344f0aa 
The `content` class applies a flex order as well which repositions the contents of the div, which isn’t desirable. Just apply the column directly instead.

Fixes #8544
@dragonstyle dragonstyle mentioned this issue Feb 4, 2024
Merged
dragonstyle added a commit that referenced this issue Feb 4, 2024
@dragonstyle
Website About - fix layout
c1e162e 
The `content` class applies a flex order as well which repositions the contents of the div, which isn’t desirable. Just apply the column directly instead.

Fixes #8544
@mcanouil mcanouil mentioned this issue Feb 15, 2024
Closed
@cwickham cwickham mentioned this issue Feb 15, 2024
Closed
@mcanouil mcanouil removed the triaged-to Issues that were not self-assigned, signals that an issue was assigned to someone. label Feb 16, 2024
@mcanouil mcanouil reopened this Feb 16, 2024
@mcanouil mcanouil self-assigned this Feb 16, 2024
mcanouil added a commit to mcanouil/quarto-cli that referenced this issue Feb 16, 2024
@mcanouil
fix: About page behaviour changed between 1.4.533 and 1.4.534
9cb4b2b 
Follow-up

Fixes quarto-dev#8544
@mcanouil mcanouil mentioned this issue Feb 16, 2024
Closed
@mcanouil
Copy link
Collaborator Author

I found a fix (#8753) (cc @dragonstyle)

@dragonstyle
Copy link
Collaborator

I believe this is now fixed as of:

0128bfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dragonstyle dragonstyle

@mcanouil mcanouil

Labels
bug Something isn't working websites Issues creating websites
Projects
None yet
Milestone
v1.5
2 participants
@dragonstyle @mcanouil