Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.33.4 bump to fix panic on windows invalid cert fetch #6303

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

cscheid
Copy link
Collaborator

@cscheid cscheid commented Jul 21, 2023

This fixes the issue that @cderv is experiencing on Windows.

@cscheid cscheid requested a review from cderv July 21, 2023 15:54
@cscheid cscheid self-assigned this Jul 21, 2023
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that running quarto from this branch solves the Panic issue

The CI issue seems to be 403 github auth problem. Not sure if this Github Issue or our Token issue (rate limit ?)
They add issue this morning with API : https://www.githubstatus.com/incidents/6503rcn8s34s

But the limit is quite high

When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

but

If you exceed the rate limit, the response will have a 403 status and the x-ratelimit-remaining header will be 0:

So possible. I'll check if we do set the right token for all the calls we have to github

@cscheid
Copy link
Collaborator Author

cscheid commented Jul 21, 2023

I can confirm that running quarto from this branch solves the Panic issue

Ok. I'm going to run the test suite locally too before I merge.

@cderv
Copy link
Collaborator

cderv commented Jul 21, 2023

FYI I triggered a manual run for smokes test in sequential: https://github.com/quarto-dev/quarto-cli/actions/runs/5624530557

It seems to run ok. so probably a rate limit thing.

@cscheid cscheid merged commit 71534d0 into main Jul 21, 2023
9 of 49 checks passed
@cscheid cscheid deleted the chore/2023-07-deno-bump branch July 21, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants