Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken external links #1053

Merged
merged 9 commits into from
Mar 21, 2024
Merged

fix: broken external links #1053

merged 9 commits into from
Mar 21, 2024

Conversation

mcanouil
Copy link
Contributor

@mcanouil mcanouil commented Mar 16, 2024 •
edited

This pull request fixes broken external links in the documentation and updates outdated URLs to ensure that all links are working correctly.

From quarto-dev/quarto-cli#9005 three links not fixed where one comes from Quarto CLI (see the issue for details).

Getting links from: https://quarto.org/docs/dashboards/examples/index.html
https://github.com/jjallaire/ojs-penguins-dashboard/blob/main/penguins.qmd
-> Very likely a "private repository" => Awaiting feedback about visibility change of the repository.

@mcanouil mcanouil changed the title fiw: broken external links fix: broken external links Mar 16, 2024
mcanouil
mcanouil commented Mar 16, 2024
View reviewed changes
docs/authoring/tables.qmd Outdated Show resolved Hide resolved
@mcanouil mcanouil marked this pull request as ready for review March 16, 2024 21:41
@mcanouil
Copy link
Contributor Author

CC @cderv @cwickham This PR is way shorter and I added the freeze directly.

@mcanouil @cwickham
fix: wording
011cb20 
Co-authored-by: Charlotte Wickham <cwickham@gmail.com>
@cwickham
Copy link
Collaborator

/deploy-preview

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-1053--mystifying-jepsen-fa4396.netlify.app

@mcanouil
Copy link
Contributor Author

I'll rerun the checks on the preview later today.

mcanouil
mcanouil commented Mar 20, 2024
View reviewed changes
docs/tools/neovim.qmd Outdated Show resolved Hide resolved
@cderv
Copy link
Collaborator

cderv commented Mar 20, 2024

/deploy-preview

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-1053--mystifying-jepsen-fa4396.netlify.app

@mcanouil mcanouil mentioned this pull request Mar 20, 2024
Closed
@cderv
Copy link
Collaborator

cderv commented Mar 20, 2024

/deploy-preview

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-1053--mystifying-jepsen-fa4396.netlify.app

@cderv
Copy link
Collaborator

cderv commented Mar 21, 2024

Thanks for the update !

@cderv cderv merged commit 8241266 into quarto-dev:main Mar 21, 2024
2 checks passed
@mcanouil mcanouil deleted the fix/external-links branch March 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwickham cwickham cwickham left review comments

@cderv cderv cderv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mcanouil @cwickham @cderv