Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executeSelection method to the extension host cell executor #436

Merged
merged 6 commits into from
May 22, 2024

Conversation

juliasilge
Copy link
Collaborator

This is just draft for now! I need to get some feedback for this.

@jjallaire
Copy link
Contributor

From my standpoint this look like it does the quarto extension bits exactly right.

@juliasilge juliasilge marked this pull request as ready for review May 21, 2024 20:50
@cderv cderv requested a review from cscheid May 22, 2024 09:22
Copy link
Collaborator

@DavisVaughan DavisVaughan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in relation to how this hooks up to the other side

apps/vscode/src/host/index.ts Outdated Show resolved Hide resolved
@cscheid
Copy link
Contributor

cscheid commented May 22, 2024

We'll deal with the autoformatting churn in future PRs. This looks ready to go 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants