JobKey, TriggerKey and Key<T> are now immutable #1375
Conversation
Remove protected default ctor of Key<T>.
|
Don't you just love serialization magic ... :( |
|
@lahma I'm not asking this specifically for this PR (but your answer could drive what we decide to do with this one), but is it ok to achieve backward compatibility for JSON serialization through the introduction of a custom JsonConverter (which would have to be plugged into Meaning, is it ok to make changes (like those in this PR) if we can support and generate the same on-the-wire (JSON) format? |
|
I'm not sure if I'm answering your question, but as long as we can deserialize data persisted to database we should be OK. This includes, triggers, jobs and calendars. |
|
@lahma Have you already shipped a version with nullable annotations? We're not very "honest" about the nullability characteristics on several properties. |
|
I think I have: #866 |
Made JobKey, TriggerKey and Key<T> immutable, and therefore Key<T> no longer defines a default protected ctor.
The implementation of
Equals(object? obj)has simplified due to this change, but the positive effect on micro-benchmarks (that I added in this PR) is within noise range.