Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TaskExtensions.IsCompletedSuccessfully(this Task t) #1387

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
107 changes: 107 additions & 0 deletions src/Quartz.Tests.Unit/TaskExtensionsTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
using NUnit.Framework;
using System;
using System.Threading;
using System.Threading.Tasks;

namespace Quartz.Tests.Unit
{
[TestFixture]
public class TaskExtensionsTest
{
[Test]
public void IsCompletedSuccessfully_Created()
{
var task = new Task(() => Task.Delay(300));

Assert.False(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.Created, task.Status);
}

[Test]
public void IsCompletedSuccessfully_WaitingToRun()
{
var task = new Task(() => Thread.Sleep(300));
task.Start();

Assert.False(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.WaitingToRun, task.Status);
}

[Test]
public void IsCompletedSuccessfully_Running()
{
var task = new Task(() => Thread.Sleep(300));
task.Start();

task.Wait(50);

Assert.False(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.Running, task.Status);
}

[Test]
public void IsCompletedSuccessfully_WaitingForActivation()
{
var task = Task.Run(() => Task.Delay(300));

Assert.False(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.WaitingForActivation, task.Status);
}

[Test]
public void IsCompletedSuccessfully_Canceled()
{
var tokenSource = new CancellationTokenSource();
CancellationToken ct = tokenSource.Token;

var task = Task.Run(() =>
{

while (true)
{
ct.ThrowIfCancellationRequested();
}
}, ct);

tokenSource.Cancel();

try
{
task.GetAwaiter().GetResult();
Assert.Fail();
}
catch (OperationCanceledException)
{
Assert.False(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.Canceled, task.Status);
}
}

[Test]
public void IsCompletedSuccessfully_Faulted()
{
var task = Task.Run(() => throw new ApplicationException());

try
{
task.GetAwaiter().GetResult();
Assert.Fail();
}
catch (ApplicationException)
{
Assert.False(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.Faulted, task.Status);
}
}

[Test]
public void IsCompletedSuccessfully_RanToCompletion()
{
var task = Task.Run(() => { });
task.Wait(30);

Assert.True(task.IsCompletedSuccessfully());
Assert.AreEqual(TaskStatus.RanToCompletion, task.Status);
}
}
}
8 changes: 6 additions & 2 deletions src/Quartz/TaskExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ internal static class TaskExtensions
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static bool IsCompletedSuccessfully(this Task t)
{
return t.Status == TaskStatus.RanToCompletion && !t.IsFaulted && !t.IsCanceled;
}
#if NETSTANDARD2_1_OR_GREATER || NETCOREAPP2_0_OR_GREATER
return t.IsCompletedSuccessfully;
#else
return t.Status == TaskStatus.RanToCompletion;
#endif
}
}
}