Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add migration for POSITION state #609

Closed
wants to merge 2 commits into from
Closed

Conversation

ajansari95
Copy link
Member

1. Overview

  • add migration for POSITION state to be compatible with new struct

2. Implementation details

3. How to test/use

4. Checklist

  • Does the Readme need to be updated?

5. Limitations (optional)

6. Future Work (optional)

Copy link
Collaborator

@arhamchordia arhamchordia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test for the migration.

arhamchordia
arhamchordia previously approved these changes May 31, 2024
Copy link
Collaborator

@arhamchordia arhamchordia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with mock migrate.

magiodev
magiodev previously approved these changes May 31, 2024
@ajansari95 ajansari95 closed this May 31, 2024
@magiodev magiodev reopened this Jun 4, 2024
ajansari95 added a commit that referenced this pull request Jun 4, 2024
@magiodev magiodev changed the base branch from main to fix/consolidated-migrate June 4, 2024 13:04
@magiodev magiodev changed the base branch from fix/consolidated-migrate to main June 4, 2024 13:05
@magiodev magiodev dismissed stale reviews from arhamchordia and themself June 4, 2024 13:05

The base branch was changed.

@magiodev magiodev closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants