Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidated migrate #614

Merged
merged 6 commits into from
Jun 4, 2024
Merged

fix: consolidated migrate #614

merged 6 commits into from
Jun 4, 2024

Conversation

ajansari95
Copy link
Member

1. Overview

2. Implementation details

3. How to test/use

4. Checklist

  • Does the Readme need to be updated?

5. Limitations (optional)

6. Future Work (optional)

@magiodev magiodev marked this pull request as ready for review June 4, 2024 13:37
Copy link
Member

@magiodev magiodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good now, all the changes have been merged here, as long as the migrate workflows from various fixes and the tests have been enhanced / are passing.

Copy link
Contributor

@LaurensKubat LaurensKubat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@magiodev magiodev merged commit 40287ee into main Jun 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants