fix: Action sheet bug #1007

quasarframework · Oct 17, 2017 · 3bded76 · 3bded76
1 parent 3c4b24e
commit 3bded76
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/components/action-sheet/ActionSheet.vue b/src/components/action-sheet/ActionSheet.vue
@@ -7,7 +7,7 @@
   >
 
     <!-- iOS -->
-    <div v-once v-if="$q.theme === 'ios'">
+    <div v-if="$q.theme === 'ios'">
       <div class="q-action-sheet">
         <div v-if="title" class="modal-header" v-html="title"></div>
 
@@ -62,8 +62,8 @@
       </div>
     </div>
 
-    <!-- Material/Default for custom theme -->
-    <div v-once v-else>
+    <!-- Material theme -->
+    <div v-else>
       <div v-if="title" class="modal-header" v-html="title"></div>
 
       <div class="modal-scroll">
@@ -133,9 +133,6 @@ export default {
     dismiss: Object
   },
   computed: {
-    opened () {
-      return this.$refs.dialog.active
-    },
     contentCss () {
       if (this.$q.theme === 'ios') {
         return {backgroundColor: 'transparent'}
@@ -144,7 +141,7 @@ export default {
   },
   methods: {
     close (fn) {
-      if (!this.opened) {
+      if (!this.$refs.dialog.active) {
         return
       }
       const hasFn = typeof fn === 'function'

diff --git a/src/utils/modal.js b/src/utils/modal.js
@@ -6,7 +6,7 @@ export default function (component) {
       const node = document.createElement('div')
       document.body.appendChild(node)
 
-      let vm = new Vue({
+      const vm = new Vue({
         el: node,
         data () {
           return {props}