Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll bar appears with devicePixelRatio = 1.25 #10120

Closed
vneznaikin opened this issue Jul 19, 2021 · 8 comments
Closed

Scroll bar appears with devicePixelRatio = 1.25 #10120

vneznaikin opened this issue Jul 19, 2021 · 8 comments

Comments

@vneznaikin
Copy link

With devicePixelRatio = 1.25 (recommended for many displays in Windows 10), the "min-height" of the main and div.q-layout tags is calculated by one pixel longer. The scroll bar appears!

To Reproduce
Steps to reproduce the behavior:

  1. Go to Windows display settings and in "Scale and layout" change to 125%
  2. Open https://quasar.dev/layout-builder
@hawkeye64
Copy link
Member

@vneznaikin This is expected when working with fractional amounts.
Also, it's recommended for screens with higher resolutions, regardless of OS.

@vneznaikin
Copy link
Author

why still not fixed?

@hawkeye64
Copy link
Member

Duplicate: #11169

rstoenescu added a commit that referenced this issue Jan 7, 2022
@rstoenescu
Copy link
Member

Fixed it in Quasar v2.4.4 & v1.17.1 (to be released)

rstoenescu added a commit that referenced this issue Jan 7, 2022
@yureckey
Copy link
Contributor

Not sure should I post a new bug report or it's a continuation of this one.
I've spent quite some time trying to figure out why on Chrome browser on a brand new blank project I see a scrollbar and 1-pixel wide bar near footer.
It is gone when I changed the windows10-recommended scale from 125% to 100% (but it's quite uncomfortable for eyes now)
here is codesandbox (but there is really nothing besides auto generated code with added footer and background color)
https://mdn7e.sse.codesandbox.io/
https://codesandbox.io/s/condescending-elbakyan-mdn7e?file=/src/layouts/MainLayout.vue

@pdanpdan pdanpdan reopened this Jan 27, 2022
@pdanpdan
Copy link
Collaborator

I've reopened - https://mdn7e.sse.codesandbox.io/ reproduces it even with HiDPI 100% but a browser zoom of 125% on linux Chrome

@yureckey
Copy link
Contributor

I've reopened - https://mdn7e.sse.codesandbox.io/ reproduces it even with HiDPI 100% but a browser zoom of 125% on linux Chrome

yes, on windows10 Chrome with browser zoom 125% I see scrollbar and 1-pixel bar. with browser zoom 110% I see only 1-pixel bar, no scrollbar. But I wasn't sure if browser zoom level differences in look are considered as bugs

rstoenescu added a commit that referenced this issue Jan 29, 2022
…void problems with zoom/HiDPI #10120 (#12234)

* fix(Screen): use viewport to get window size to avoid problems with zoom/HiDPI #10120

#10120

* fix(Screen): include scrollbar in size

* Update Screen.js

Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.5.0 and v1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants