Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q-Btn on Safari doesn't display properly when using :to #10636

Closed
maggie44 opened this issue Sep 10, 2021 · 6 comments
Closed

Q-Btn on Safari doesn't display properly when using :to #10636

maggie44 opened this issue Sep 10, 2021 · 6 comments
Labels

Comments

@maggie44
Copy link
Contributor

maggie44 commented Sep 10, 2021

Describe the bug
When using to or :to on a q-btn the style changes when viewing through Safari (iPhone and Desktop Safari) (Firefox works ok), and doesn't seem to respond to the style requests.

Screenshot 2021-09-10 at 08 36 39

Codepen/jsFiddle/Codesandbox (required)
Unfortunately I haven't been able to reproduce this in Codepen, it displays ok through their built in browser. But dropping the below code in a Quasar dev env and viewing through Safari produces the issue.

To Reproduce
Steps to reproduce the behavior:

    <q-btn
      icon="folder_open"
      outline
      dense
      flat
      to="/"
    />
    <q-btn
      icon="folder_open"
      outline
      dense
      flat
    />

Expected behavior
Both these buttons should look the same like they do on Firefox (tested with Developer Edition):
Screenshot 2021-09-10 at 08 54 59

Platform (please complete the following information):
Quasar Version:
@quasar/app Version: 2.0.4

Safari:
Version 14.1.1 (16611.2.7.1.4)

@pdanpdan
Copy link
Collaborator

Please check the styles in Safari's inspector.
I cannot reproduce it.

@maggie44
Copy link
Contributor Author

Poor investigation on my part, my apologies.

Further investigation suggests it is Safari + Quasar + Tailwinds. The issue occurs as I mention above, but only when tailwinds is installed alongside Quasar. I'm not sure if this makes it a Quasar issue or a Tailwinds one, I will take your guidance on that.

I have attached here a new project I created to reproduce the error. It is a Quasar project created using the Quasar CLI + a tailwinds setup as described here (https://dev.to/eltoritoelvis/add-tailwind-css-to-your-quasar-project-in-5-minutes-or-less-3n4o). Using Safari mobile and desktop the issue occurs, but not in Firefox.

Screenshot 2021-09-18 at 17 03 43

safari-issue.zip

@maggie44
Copy link
Contributor Author

Is it viable to get this one marked as reopened?

@pdanpdan
Copy link
Collaborator

It's a style from tailwind that breaks it. Nothing we can do about it, sorry.

@maggie44
Copy link
Contributor Author

It's a style from tailwind that breaks it. Nothing we can do about it, sorry.

Thanks for checking it out.

The Tailwind guys have identified an issue and suggested there is an issue with one of the attributes on the Quasar end. Here is the info: tailwindlabs/tailwindcss#5609 (comment)

@rstoenescu
Copy link
Member

Fix will be available in Quasar v2.1.3

pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 10, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 10, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 13, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 13, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 13, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 13, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 13, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 14, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 17, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 20, 2021
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Dec 27, 2021
rstoenescu added a commit that referenced this issue Dec 28, 2021
…1640)

* feat(router-link): add href and target - backport from Qv2 #10636

* Update router-link.js

Co-authored-by: Razvan Stoenescu <razvan.stoenescu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants