Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router-link): add href and target - backport from Qv2 #10636 #11640

Merged
merged 2 commits into from
Dec 28, 2021

Conversation

pdanpdan
Copy link
Collaborator

@pdanpdan pdanpdan commented Dec 10, 2021

If it is disable and type is not 'a' then it must render as button (link cannot be disabled)

If it renders as link ():

  • it must not have type (except if type is a MediaType)
  • if it has href it does not need a role - it is link by default
  • if it does not have href then if does need role=button

If it renders as button:

  • the type must be one of 'button', 'submit', 'reset'
  • it does not need a role

@pdanpdan pdanpdan force-pushed the feature/v1-btn-type-role-href branch from 2bb3ba0 to 77f1965 Compare December 27, 2021 20:59
@pdanpdan pdanpdan changed the title feat(QBtn): improve type/href/role detection #10636 feat(router-link): add href and target - backport from Qv2 #10636 Dec 27, 2021
@pdanpdan pdanpdan force-pushed the feature/v1-btn-type-role-href branch from 77f1965 to 644e627 Compare December 27, 2021 21:19
@pdanpdan pdanpdan force-pushed the feature/v1-btn-type-role-href branch from 644e627 to b8ae687 Compare December 27, 2021 21:23
@rstoenescu rstoenescu merged commit db00d7a into quasarframework:v1 Dec 28, 2021
@pdanpdan pdanpdan deleted the feature/v1-btn-type-role-href branch December 28, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants