Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q-stepper Active-icon problem #12547

Open
AlaaDq opened this issue Feb 21, 2022 · 6 comments
Open

Q-stepper Active-icon problem #12547

AlaaDq opened this issue Feb 21, 2022 · 6 comments

Comments

@AlaaDq
Copy link

AlaaDq commented Feb 21, 2022

What happened?

i am trying to follow the docs about using active icon
Icon name following Quasar convention; If 'none' (String) is used as value, then it will defer to prefix or the regular icon for this state; Make sure you have the icon library installed unless you are using 'img:' prefix

when using none as value to disable default icon it is not showing the prefix and nothing is appearing.

What did you expect to happen?

i expect to see prefix on active icon

Reproduction URL

https://codepen.io/Alaa-Dq/pen/jOazJrr?editors=101

How to reproduce?

add prefix="1" and activeIcon="none" to q-step

Flavour

Quasar CLI (@quasar/cli | @quasar/app)

Areas

Components (quasar)

Platforms/Browsers

Chrome

Quasar info output

No response

Relevant log output

No response

Additional context

No response

@MilosPaunovic
Copy link
Member

You've gotta bind it, like this :active-icon="none"
https://codepen.io/milospaunovic/pen/vYWRMbm?editors=1010

@AlaaDq
Copy link
Author

AlaaDq commented Feb 21, 2022

image

but it looks the same the active icon still the pen and not none or prefix ="1"

@MilosPaunovic
Copy link
Member

Oh, I didn't understand well. Codepen is edited, for the first step active icon isn't shown anymore
https://codepen.io/milospaunovic/pen/vYWRMbm?editors=1010

@AlaaDq
Copy link
Author

AlaaDq commented Feb 21, 2022

but as docs they said
Icon name following Quasar convention; If 'none' (String) is used as value,

then it will defer to prefix or the regular icon for this state
but the prefix not appear i need to see the prefix here as "1" for example when it is active
hope the problem is clear now

@MilosPaunovic
Copy link
Member

I do understand your requirement now, but I'm afraid that the docs were a bit misleading in that case, if I understand this piece of code which handles active step icon:

if (isActive.value === true) {

If someone else could confirm, that would be great.

@AlaaDq
Copy link
Author

AlaaDq commented Feb 21, 2022

Thanks for your time bro

pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 19, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 19, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 25, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Mar 25, 2022
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 5, 2023
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 8, 2023
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 10, 2023
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 11, 2023
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants