getDayOfWeek util doesn't respect the active language pack

[AlaaDq]

What happened?

import { date } from 'quasar';

date.getDayOfWeek(new Date()) // 7 (Sunday)

return Sunday(7) even when I set the default to Saturday(6) in a boot file like below

const lang = await import('quasar/lang/' + locale.isoName);
lang.default.date = { ...lang.default.date, firstDayOfWeek: 6 };

What did you expect to happen?

Return Saturday instead of Sunday by respecting the active language pack's firstDayOfWeek option.

Reproduction URL

.

How to reproduce?

overwrite default lang-pack to have its first day as

const lang = await import('quasar/lang/' + locale.isoName);
lang.default.date = { ...lang.default.date, firstDayOfWeek: 6 };

Flavour

Quasar CLI (@quasar/cli | @quasar/app)

Areas

Quasar CLI Commands/Configuration (@quasar/cli | @quasar/app), Quasar Extras (@quasar/extras)

Platforms/Browsers

Chrome

Quasar info output

No response

Relevant log output

No response

Additional context

No response

[github-actions]

Hi @AlaaDq! 👋

It looks like you provided an invalid or unsupported reproduction URL.
Do not use any service other than Codepen, jsFiddle, Codesandbox, and GitHub.
Make sure the URL you provided is correct and reachable. You can test it by visiting it in a private tab, another device, etc.
Please edit your original post above and provide a valid reproduction URL as explained.

Without a proper reproduction, your issue will have to get closed.

Thank you for your collaboration. 👏

[pdanpdan]

Sorry, can you explain how the first day of the week would change the current day of the week?

[AlaaDq]

@pdanpdan
date.getDayOfWeek(new Date()) return 1; =>{ 0 =>sun ,1=>mon}
but it should became =>{ 0 =>sat,1=>sun,2=>mon}

[AlaaDq]

@pdanpdan
hope it is clear now

[MilosPaunovic]

@AlaaDq You can pass custom locale object with your firstDayOfWeek property.
https://v1.quasar.dev/vue-components/date#custom-ad-hoc-locale

Dan, I've managed to reproduce the issue - if you try to change the locale object in the way as OP, like this:

const lang = await import('quasar/lang/' + locale.isoName);
lang.default.date = { ...lang.default.date, firstDayOfWeek: 6 };

The datetime.js mixin at this line:

quasar/ui/src/mixins/datetime.js

Line 77 in af5a920

__getLocale () {

Does not take changes into account - locale is undefined and $q.lang.date returns default values. Don't know if that's desired behaviour.

[AlaaDq]

no this is not the case i am looking for , i have locale defined and the QDate component taked the change i need
but the date utils doesn't and still consider sunday as first day

[AlaaDq]

i just need to achive first day of week is saturday in date utils too and not only in QDate component

[pdanpdan]

The return value is always (and should be) the same from Date.getDay (0 - Sunday)
Else you would not be able to use it anywhere because all js localization functions use that convention.

[pdanpdan]

When I get to my computer I'll post a conversion function

[AlaaDq]

what if i do something like this ,

const lang = await import('quasar/lang/' + locale.isoName);
lang.default.date = { ...lang.default.date,  days: 'Saturday_Sunday_Monday_Tuesday_Wednesday_Thursday_Friday'.split('_'),: 6 };

is this going to work?

[pdanpdan]

Ok, I've checked the code.
I'm not very sure which is the point of how it works, because it does not match the getDay behaviour and it does not count using the defined start of week day.

What it does now: it returns getDay value except for Sunday for which it returns 7.

@rstoenescu Should we change it to return the 1-indexed position of the day in the week as defined by the locale?

[AlaaDq]

That is what I was need actually
Because in Asia the week start from Saturday not Sunday 😁