Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display issue with focused QSelect in Firefox [v1.2.2] #5320

Closed
GordonBlahut opened this issue Oct 16, 2019 · 1 comment · Fixed by #5321
Closed

Display issue with focused QSelect in Firefox [v1.2.2] #5320

GordonBlahut opened this issue Oct 16, 2019 · 1 comment · Fixed by #5321
Assignees
@pdanpdan
Labels
kind/bug 🐞

Comments

@GordonBlahut
Copy link

Describe the bug
There is a visible artifact to the left of focused QSelect controls in Firefox. It looks kinda like a backtick.

Codepen/jsFiddle/Codesandbox (required)
You can see it in the docs: https://quasar.dev/vue-components/select

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://quasar.dev/vue-components/select in Firefox
  2. Click on any QSelect

Expected behavior
It shouldn't be there.

Screenshots
image of QSelect

Platform
Quasar:1.2.2
OS: Windows_NT(10.0.18362) - win32/x64
Browsers: Firefox 69.0.3

Additional context
Screenshots from Windows but also verified present in Firefox on macOS.
Seems to be caused by the <div> inside .q-field__native, highlighted here:
image of Firefox devtools
@GordonBlahut GordonBlahut changed the title Display issue with QSelect in Firefox [v1.2.2] Display issue with focused QSelect in Firefox [v1.2.2] Oct 16, 2019
@pdanpdan pdanpdan self-assigned this Oct 16, 2019
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 16, 2019
@pdanpdan
fix(QSelect): Hide focus target outline (Firefox)
15960c4 
close quasarframework#5320
@pdanpdan pdanpdan mentioned this issue Oct 16, 2019
Merged
pdanpdan added a commit to pdanpdan/quasar that referenced this issue Oct 16, 2019
@pdanpdan
fix(QSelect): Hide focus target outline (Firefox)
45ca4dc 
close quasarframework#5320
rstoenescu pushed a commit that referenced this issue Oct 16, 2019
@pdanpdan @rstoenescu
fix(QSelect): Hide focus target outline (Firefox) (#5321)
fc4aba6 
close #5320
@rstoenescu
Copy link
Member

Thanks for reporting!
Fix will be available in "quasar" v1.2.3

@GordonBlahut GordonBlahut mentioned this issue Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdanpdan pdanpdan

Labels
kind/bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(QSelect): Hide focus target outline (Firefox) pdanpdan/quasar
3 participants
@pdanpdan @rstoenescu @GordonBlahut