-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmaximizing and hiding QDialog doesn't clean up properly, breaking scroll #6739
Comments
+1 for this. I noticed the same behaviour triggering QDialog from Vuex actions. Strangely enough, if I close the QDialog triggering the mutation from within the QDialog component scroll is being restored. Example: // Inside my QDialog component
<template>
<q-dialog>
<q-btn @click="closeMe" />
// .....
</template>
<script>
closeMe() {
this.$store.commit('dialogs/MyDialog', 'close')
</script> Instead, if I submit a form within the QDialog, using a Vuex action, and inside that action try to commit('dialogs/MyDialog', 'close', {root: true}) QDialog gets closed as it should, but the underlaying page is not scrollable anymore. Even if navigation to other pages/layouts. Strangely enough, in my case the body class gets restored to If I inspect my page, and check for event listeners, I can see there's an event called This event is being referenced in Platform (please complete the following information): |
Edit: What I tried, and apparently worked: in
But I am not sure this will affect some other behaviour ... |
Hi, Thanks for reporting. |
Describe the bug
If
maximized
andvalue
are changed fromtrue
tofalse
simultaneously,q-body--dialog
class is left on<body>
breaking the scrolling behavior.Codepen/jsFiddle/Codesandbox (required)
https://jsfiddle.net/mkrnic/suxbLgaj/8/
To Reproduce
Expected behavior
<body>
shouldn't haveq-body--dialog
class after closing the dialog.Platform (please complete the following information):
OS: Linux
Node: any
NPM:any
Yarn: any
Browsers: Chrome
iOS:
Android:
Electron:
Additional context
Looks very similar to #5798
The text was updated successfully, but these errors were encountered: