-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replacing aliasing with aliasHQ #15702
base: dev
Are you sure you want to change the base?
feat: replacing aliasing with aliasHQ #15702
Conversation
This pr is not fit for merging yet. The main reason it that although it can do the aliasing via aliasHQ, currently aliasHQ is using a JSON parser that does not recognize comments. An issue has been created in the aliasHQ repo for this. In the meanwhile I'll try to resolve this isssue by forking aliasHQ and making a pr for it. We can proceed according by either
Following was the effort made towards this issue:- First a research was done on what are good aliasing solutions that can be implemented. Below is a snippet of my feedback before we went for using aliasHQ. Below are some solutions I found for this https://github.com/ilearnio/module-alias Perosonal Recommendations: I referred to this article and alias hq seems like an overall good and managed option. Will add more to this if I find something else. I tried to dive a bit deeper into the nuxt repo. It seems that nuxt is manually resolving the paths for aliasing. pros |
Hi, This PR is not acceptable into the core because it adds yet another dependency with little value to the majority of our users. But the main problem is that in its current form it breaks the expected pre-configured aliases. However, you can configure alias-hq to use it in your own projects with no problem. |
@Nike682631 meant to ask my review, he forgot to ping me We can switching to Nuxt way of doing so, using
The PR main aim is to ease the project maintenance This is also a first step towards refreshing Capacitor/Electron support, since their usage with TS (and IDE in general) is clunky due to bundlers aliases not being in sync with TS ones We're already using AliasHQ into Jest testing AE to automatically replicate a project aliases into Jest
The change is meant to be fully backwards compatible and transparent to users, which shouldn't know which package we're using under the hood, I just didn't have the chance to review and help iterate on it yet |
Hey @rstoenescu! Alias HQ author here; just catching up on this PR after answering some questions on it by @Nike682631 and @IlCallo . Totally respect your decision regarding using the lib, was just wondering if you have time to clarify your comment regarding "breaking pre-configured aliases" ? Would be good for me to know the use cases where it may not be useful / appropriate / compatible. 🙏 |
Hi there! Was referring to the fact that our current list of aliases are replaced by I'm going to reopen this and would love to have a chat with you on Discord over AliasHQ. Maybe I closed this too early. |
Cool! I messaged you ( |
As long as jsconfig and tsconfig aliases are defined, AliasHQ is capable of keeping them in sync automatically |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: