Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max-height option like Autocomplete one #2531

Merged
merged 2 commits into from
Sep 7, 2018
Merged

Add max-height option like Autocomplete one #2531

merged 2 commits into from
Sep 7, 2018

Conversation

amfine-soft-scheminel
Copy link
Contributor

Hi

Goal : Introduce the hability to limit QPopover height on QSelect like it's already done on QAutocomplete.

This PR goal is to be able to implement with QSelect the workaround describe in :
#2530
In case there is too much options to display it'll help to limit QPopover height.

Thx

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Sébastien Cheminel and others added 2 commits September 7, 2018 14:39
Introduce the Hability to limit Qpopover height in case there is too
much options to display.
@rstoenescu rstoenescu merged commit e517328 into quasarframework:dev Sep 7, 2018
@rstoenescu
Copy link
Member

Thanks for supplying a PR. Changed prop name to "popup-max-height" though.

@rstoenescu rstoenescu added this to the v0.17.13 milestone Sep 7, 2018
@amfine-soft-scheminel
Copy link
Contributor Author

Nota Bene : I suggest max-height as it was max-height in AutoComplete.

Maybe you should use the same properties in both Widget ?

Thanks for accepting my PR.

@rstoenescu
Copy link
Member

I think it's better for the props name to be as explicit as possible, otherwise in this case some devs might think max-height is referring to the input max-height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants