Skip to content
Permalink
Browse files

Make sure that clients can't access buffers belonging to other users

A manipulated, but properly authenticated client was able to retrieve
the backlog of other users on the same core in some cases by providing
an appropriate BufferID to the storage engine. Note that proper
authentication was still required, so exploiting this requires
malicious users on your core. This commit fixes this issue by ensuring
that foreign BufferIDs are off-limits.
  • Loading branch information
egs-me committed Nov 24, 2013
1 parent 03c4c31 commit 1fc8eb59a87c005ddfe7d21bc225bef8692b9743
@@ -1,3 +1,3 @@
SELECT bufferid, networkid, buffertype, groupid, buffername
FROM buffer
WHERE bufferid = :bufferid
WHERE userid = :userid AND bufferid = :bufferid
@@ -17,4 +17,5 @@ rejoinchannels = :rejoinchannels,
usesasl = :usesasl,
saslaccount = :saslaccount,
saslpassword = :saslpassword
WHERE networkid = :networkid
WHERE userid = :userid AND networkid = :networkid

@@ -1,3 +1,3 @@
SELECT bufferid, networkid, buffertype, groupid, buffername
FROM buffer
WHERE bufferid = :bufferid
WHERE bufferid = :bufferid AND userid = :userid

0 comments on commit 1fc8eb5

Please sign in to comment.
You can’t perform that action at this time.