Skip to content

Commit

Permalink
core: Remove redundant updateSchemaVersion() call
Browse files Browse the repository at this point in the history
Remove the redundant updateSchemaVersion() call at the end of schema
migrations.  This is already called within the final iteration of the
loop.

Cleans up a leftover from f10304a
  • Loading branch information
digitalcircuit authored and Sput42 committed Feb 13, 2019
1 parent c3263d1 commit 63725f7
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/core/abstractsqlstorage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -324,15 +324,6 @@ bool AbstractSqlStorage::upgradeDb()
}
}

// Update the schema version for the final step. Split this out to offer more informative
// logging (though setting schema version really should not fail).
if (!updateSchemaVersion(schemaVersion())) {
// Updating the final schema version failed, bail out
qCritical() << "Unable to upgrade Logging Backend! Setting final schema version"
<< schemaVersion() << "failed.";
return false;
}

// If we made it here, everything seems to have worked!
return true;
}
Expand Down

0 comments on commit 63725f7

Please sign in to comment.