Fix OSX compile and deploy #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
doesn't work anymore … |
Set additional compile flag Fix FindLdap.cmake for OSX Fix DMG creation (sometimes fails if no volume size is provided)
romibi
force-pushed
the
fix-travis-osx-deploy
branch
from
2b0f63a
to
4cd35cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get compile errors otherwise, at least locally.
I hope the way I did it is ok. But I know it can be improved!
Use older OSX image on travis.I don't want to upgrade my old MacBook to an newer OSX version … and with the few pushs to update the scripts for newer xcode to build on travis I didn't get deploy to work, yet.
I might give this a try later again … maybe even with a new macbook …
hdiutil sometimes fails if no volume size is provided.
Fixed by taking the size of the contents (and slightly increasing it to be safe)
New since 2017-12-23:
This was the main reason why it broke if compiled on a different OSX version.
CMake should have this variable correctly set already!
Things which still can be improved:
To support KF5 stuff being deployed the deploy script needs to be modified to also rewrite absolute paths to relative paths in the linking inside ".dylib" packages in addition to ".framework" packages.
This can be done in a later PR but until that is done we can ship KF5 stuff with the OSX app.
(At least not automatically.)