Re-enable Trayicon blinking with Snore #328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change from PR #139 the update to the new Snore Notification Backend modified the behaviour of loading the SystrayNotificationBackend if Snore is enabled.
See: 79ef34a#diff-cfff7c7c664d451740ea7bda9372fc10L83
Although it makes sense to not show a message bubble if snore is enabled, the tray icon animation is handled by SystrayNotificationBackend too.
This might have been overlooked because the tray animation is not en/disabled in the notification settings:
With this PR the animation works again but the message bubble has to be disabled manually again:
This is how it was before …
It might make sense to auto toggle off the bubble when snore gets enabled, but i didn't find an easy way to do that. (And I'm not completely sure if that's something needed/wanted)
Now https://bugs.quassel-irc.org/issues/1383 should be fixed … a second time …But … Issue 13830 may still not be fixed completely …