Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Sort network name case-insensitively #437

Merged
merged 1 commit into from Oct 14, 2018
Merged

client: Sort network name case-insensitively #437

merged 1 commit into from Oct 14, 2018

Conversation

digitalcircuit
Copy link
Contributor

In short

  • Sort buffer views case-insensitively, including network name
    • Primarily affects network name; channels/PMs already appear to be correctly sorted
    • Still able to rearrange channels/PMs when sorting is disabled
    • Doesn't provide control over sorting networks (same as before)
Criteria Rank Reason
Impact ★☆☆ 1/3 User-facing network sorting consistency
Risk ★☆☆ 1/3 Network order may change; workflows might be upset
Intrusiveness ★☆☆ 1/3 Small set of changes, shouldn't interfere with other pull requests

Rationale

Quassel sorts most things alphabetically in a case-insensitive manner, including the nickname list. The network name list should also be sorted case-insensitively to match.

Examples

Setup

Add three networks, Alpha, beta, and Freenode.

Before

  • Alpha
  • Freenode
  • beta

After

  • Alpha
  • beta
  • Freenode

@digitalcircuit
client: Sort network name case-insensitively
581da99 
Set BufferViewFilter to sort case-insensitively.  This results in
network names being sorted regardless of case.  Channel/nickname
sorting is handled elsewhere.

Before:
> Alpha
> Freenode
> beta

After:
> Alpha
> beta
> Freenode

This probably matches expectations better, and hopefully doesn't
break existing workflows too much...  https://xkcd.com/1172/
@Sput42 Sput42 merged commit e61d189 into quassel:master Oct 14, 2018
@digitalcircuit digitalcircuit deleted the ft-network-sort-caseinsensitive branch October 14, 2018 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@digitalcircuit @Sput42