[0.13] core: Internal identd listen all, fix config-from-env

[digitalcircuit]

In short

• Allow specifying internal identd listening addresses, not just local
• Fix --config-from-environment first-time setup ignoring other CLI arguments

Criteria	Rank	Reason
Impact	★★☆ 2/3	Fixes first-time ENV configuration, allows identd without oidentd
Risk	★☆☆ 1/3	Opens internal identd, users should be careful
Intrusiveness	★★☆ 2/3	New log strings, shouldn't interfere with other pull requests

All credit to @justjanne including the work backporting - this is just opening the PR and doing a basic test.

Rationale

See the master branch pull request #457, "Fixes for identd and config-from-environment".

Example

Quassel core: default

Command

$ ./run-quasselcore.sh --ident-daemon

Outcome

Quassel core identd is listening on local addresses.

$ netstat --listen
tcp        0      0 localhost:10113         *:*                     LISTEN
tcp6       0      0 ip6-localhost:10113     [::]:*                  LISTEN

Quassel core: all addresses

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen ::,0.0.0.0

Outcome

Quassel core identd is listening on all addresses.

$ netstat --listen
tcp        0      0 *:10113                 *:*                     LISTEN
tcp6       0      0 [::]:10113              [::]:*                  LISTEN

Quassel core: all IPv6, unavailable IPv4

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen ::,1.1.1.1

Outcome

Quassel core identd is listening on all IPv6 addresses, no IPv4.

$ netstat --listen
tcp6       0      0 [::]:10113              [::]:*                  LISTEN

2019-02-13 02:15:43 [Info ] Listening for GUI clients on IPv6 :: port 4242 using protocol version 10 
2019-02-13 02:15:43 [Info ] Listening for GUI clients on IPv4 0.0.0.0 port 4242 using protocol version 10 
2019-02-13 02:15:43 [Info ] Listening for identd requests on IPv6 :: port 10113 
2019-02-13 02:15:43 [Warn ] Could not open IPv4 interface 1.1.1.1:10113: The address is not available 
2019-02-13 02:15:43 [Info ] Restoring previous core state...

Quassel core: all IPv6, local IPv4

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen ::,127.0.0.1

Outcome

Quassel core identd is listening on all IPv6 addresses, only local IPv4.

$ netstat --listen
tcp        0      0 localhost:10113         *:*                     LISTEN
tcp6       0      0 [::]:10113              [::]:*                  LISTEN

Quassel core: all IPv6, local IPv4, custom port

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen ::,127.0.0.1 --ident-port 55555

Outcome

Quassel core identd is listening on all IPv6 addresses, only local IPv4, on port 55555.

$ netstat --listen
tcp        0      0 localhost:55555         *:*                     LISTEN
tcp6       0      0 [::]:55555              [::]:*                  LISTEN

Quassel core Qt 4: default

Command

$ ./run-quasselcore.sh --ident-daemon

Outcome

Quassel core identd is listening on local addresses.

$ netstat --listen
tcp        0      0 localhost:10113         *:*                     LISTEN
tcp6       0      0 ip6-localhost:10113     [::]:*                  LISTEN

Quassel core Qt 4: all addresses

Command

Note: the Qt 4 argument parser requires an = to set long options.

$ ./run-quasselcore.sh --ident-daemon --ident-listen=::,0.0.0.0

Outcome

Quassel core identd is listening on all addresses.

$ netstat --listen
tcp6       0      0 [::]:10113              [::]:*                  LISTEN

Despite not showing up in netstat, nmap "localhost" -p 10113 shows the port as open. IPv4v6 dual-listening, perhaps..?

2019-02-13 02:42:33 [Info ] Listening for GUI clients on IPv6 :: port 4242 using protocol version 10 
2019-02-13 02:42:33 [Info ] Listening for identd requests on IPv6 :: port 10113 
2019-02-13 02:42:33 [Info ] Restoring previous core state...

Quassel core Qt 4: all IPv6, unavailable IPv4

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen=::,1.1.1.1

Outcome

Quassel core identd is listening on all IPv6 addresses, no IPv4.

$ netstat --listen
tcp6       0      0 [::]:10113              [::]:*                  LISTEN

2019-02-13 02:49:06 [Info ] Listening for GUI clients on IPv6 :: port 4242 using protocol version 10 
2019-02-13 02:49:06 [Info ] Listening for identd requests on IPv6 :: port 10113 
2019-02-13 02:49:06 [Warn ] Could not open IPv4 interface 1.1.1.1:10113: The address is not available 
2019-02-13 02:49:06 [Info ] Restoring previous core state...

Quassel core Qt 4: all IPv6, local IPv4

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen=::,127.0.0.1

Outcome

Quassel core identd is listening on all IPv6 addresses, and likely all IPv4. This appears to be a Qt 4 limitation. See earlier tests.

$ netstat --listen
tcp6       0      0 [::]:10113              [::]:*                  LISTEN

Quassel core Qt 4: all IPv6, local IPv4, custom port

Command

$ ./run-quasselcore.sh --ident-daemon --ident-listen=::,127.0.0.1 --ident-port=55555

Outcome

Quassel core identd is listening on all IPv6 addresses, and likely all IPv4, on port 55555. This appears to be a Qt 4 limitation. See earlier tests.

$ netstat --listen
tcp6       0      0 [::]:55555              [::]:*                  LISTEN

I haven't tested the --config-from-environment changes, but @justjanne is already using them in a Quassel Docker image.