[0.13] logger: Make output to syslog nicer #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2019
digitalcircuit
pushed a commit
to digitalcircuit/quassel
that referenced
this pull request
Jan 29, 2019
Resolve the level string in msgWithTime. This means that the log level string is included in logs to files and stdout even if syslog output is enabled. Closes quasselGH-472
|
Once pull request #460 has been updated, I'll update this here. Alternatively, if I'm not available in time, I've left the |
Resolve the level string in msgWithTime. This means that the log level string is included in logs to files and stdout even if syslog output is enabled. Resolve the program name using RunMode and BuildInfo, distinguishing between client, core, and monolithic. [Backported from 0.14/git-master]
digitalcircuit
force-pushed
the
backport-0.13-vehk-syslog-fixes
branch
from
ecd517f
to
8071522
Compare
Deduplicate code by moving LogEntry formatting into a separate function, LogEntry::toString(), which applies timestamps and the log level string. Fix client Debug Log dialog to print log level using this new function. Modify msgWithTime() to use this new function, too.
digitalcircuit
changed the title
|
This pull request has been updated with the changes in pull request #460, as well as an additional fix on top. It should be ready for merging. |
digitalcircuit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short
--syslogoutput[Info]--syslog, including systemdAll credit to @vehk for the original work, this is just testing and an additional fix.
Rationale
See the
masterbranch pull request #460, "Make output to syslog nicer".Example
Before
After
Additional testing with Qt 4, Qt 5, systemd
Qt 5
Qt 4