Fix problems with single character line endings #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be great if you could just put this in a single commit, put something meaningful in the subject line and a little explanation + just "Fixes #1267" (The bug tracker will catch it then) somewhere in the body. |
This fixes problems with IRC servers sending only single char line endings. Before the last char on each line for thos servers would be chopped, now Quassel checks how the line ends and chops accordingly.
netzvieh
changed the title
|
Updated. |
|
Added "Fixes #1267" and merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IRC servers just send LF line endings instead of CR-LF. Though not RFC compliant this should be handled by quassel. Quassel now checks if the line sent by the server ends with CR-LF or just LF and chops accordingly.
Fixes #1267