Mark /etc/ccm.conf as noreplace

[piojo-zz]

Existing configurations may be lost. According to http://www.mojohaus.org/rpm-maven-plugin/map-params.html this value should mark noreplace explicitly.

[ned21]

Given that the docs say the old value should work, and it worked correctly in previous releases, do we understand the root cause here?

[stdweird]

@Piojo and how many other repos need this fix?

[jouvin]

I agree with @ned21 : the true value should be fine. What is the problem you want to solve?

[stdweird]

15.8_rc3 rpms overwrite the /etc/ccm.conf

[jouvin]

If your change fixes the problem, I am fine. But the description at the URL you mentioned suggests that this should be what happens with the true value if the directory containing the configuration files is properly defined. And in fact, it worked in the past...

[piojo-zz]

@guillaume-philippon mentioned 15.8_rc3 overwrites this file. I haven't validated the change - I don't have a host with Maven and RPM at this moment. I'd appreciate if somebody could build it, and then validate that the old file is kept.

[jouvin]

@Piojo we can probably do it at LAL as we reported the problem! But the question remains why the problem appeared as the pom file should be ok with the current value...

[piojo-zz]

@stdweird , I'd review cdp-listend, ncm-ncd and ncm-cdispd for a similar pattern.

rpm -qc --qf '%{filenames}: %{fileflags}\n' cdp-listend ncm-ncd ncm-cdispd

And then, those files should show flags&16!=0

[stdweird]

@Piojo aii also has config files i think

[jouvin]

Before modifying things, I insist that we need to understand the problem. Based on the first investigation, this is a bug in the Maven plugin that doesn't set properly the noreplace flag when configuration=true. In particular ccm 15.4 has the flag properly set but not the last RPM without any change in the pom file. I'm trying to rebuild the RPM on another machine to see if this could be caused by the environmnent used to build the release... Else we need to open a bug against the plugin and see if using noreplace as proposed by Stijn works as a workaround.

[jouvin]

I rebuild the CCM RPM on one of our machine and reproduced the problem. Thus the Maven plugin seems the culprit: I'll try to report it to RPM plugin module. In the meantime, I confirm that the change proposed by Stijn works around the problem (at the expense of properly handling config files only with RPM conversely to the true value that does what is appropriate for any packaging format... but probably not an issue for us).

[jouvin]

Issue opened against Maven RPM plugin: mojohaus/rpm-maven-plugin#19.

[jouvin]

In fact, looking in more details at the Mojo RPM plugin site, it seems the last release is 2.1.4 (less than one month ago) when we are using 2.1-alpha1 according to Maven output which is pretty old... The problem may be on our side then... I'm trying to investigate.

[jouvin]

After more investigation, we found that the value used to be noreplace and that the change was introduced by mistake in b9be30f. Thus merging this PR that reverts the change in fact...

[stdweird]

@jouvin thanks for figuring this out and my apologies for making the mistake

[jouvin]

Just for the record, RPM maven plugin maintainer answered that configuration=true is not equivalent to noreplace but ensure that the local file, if it exists, is renamed with suffix .rpmold before installing the new one.