Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support active configuration attribute for plugins #280

Merged
merged 3 commits into from
Oct 27, 2021
Merged

Support active configuration attribute for plugins #280

merged 3 commits into from
Oct 27, 2021

Conversation

stdweird
Copy link
Member

Fixes #209
Requires quattor/ncm-ncd#74 and #203
Replaces #210

@stdweird stdweird added this to the 18.6 milestone Apr 26, 2018
@stdweird
Copy link
Member Author

@jrha @ned21 pls review

@stdweird stdweird mentioned this pull request Apr 26, 2018
Closed
@jrha jrha modified the milestones: 18.6, 18.9 Jul 2, 2018
@kwaegema
Copy link
Member

@stdweird this is not in qmmpack, this is as intended?

@jrha
Copy link
Member

jrha commented Nov 22, 2018

@stdweird I don't understand @kwaegema's comment, but I assume it is not an issue?

@jrha jrha modified the milestones: 18.12, 19.6 Apr 9, 2019
@jrha
Copy link
Member

jrha commented Dec 12, 2019

@stdweird have you got time to rebase and look at the comments?

@jrha jrha modified the milestones: 19.12, 20.2 Dec 20, 2019
@jrha jrha modified the milestones: 20.3, 20.4 Mar 19, 2020
@stdweird
Copy link
Member Author

@jrha ready for rereview

This was referenced May 25, 2021
Open
Open
Merged
@jrha jrha modified the milestones: 21.8, 21.6 Jun 7, 2021
jrha
jrha previously approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (AFAICT)

jrha
jrha approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jrha jrha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@jrha jrha merged commit 72894bb into quattor:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned21 ned21 ned21 left review comments

@jrha jrha jrha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
21.12
Development

Successfully merging this pull request may close these issues.

support ACTIVE_CONFIG
4 participants
@stdweird @kwaegema @jrha @ned21