aii-ks: Update regex tests to handle wipefs changes in ncm-lib-blockdevices #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evices wipe_metadata is no longer conditional, nor does it take a size argument. This was caused by the changes merged into ncm-lib-blockdevices in 7ee1375ee8db9edda1b030d6de259a2d3eae2ae9.
|
@stdweird I've merged this immediately in order to get nightlies building again, but feel free to post-review and revert if you think that this shouldn't be this way. |
|
@jrha euh, sure i guess. there are other PRs opepn to deal with wipefs, so i need to recheck them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wipe_metadatais no longer conditional, nor does it take a size argument.This was caused by the changes merged in quattor/ncm-lib-blockdevices@7ee1375.