Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.12.58: archetype/final should be optional #83

Closed
jouvin opened this issue May 21, 2018 · 2 comments
Closed

1.12.58: archetype/final should be optional #83

jouvin opened this issue May 21, 2018 · 2 comments

Comments

@jouvin
Copy link
Contributor

jouvin commented May 21, 2018

Currently the broker created profiles where the last line is include { "archetype/final" };. I can imagine that the this template is not necessarily needed and rather than creating it empty, I'd suggest that this line is replaced by:

include if_exists('archetype/final');

Note that an optional template is still part of the dependency information, so if it is added later, it will cause the profiles to be recompliled.

@jrha
Copy link
Member

jrha commented May 21, 2018

It's pretty much essential for all normal use-cases (it's the only safe way to force profile content), but I see your point.

jouvin pushed a commit to jouvin/aquilon that referenced this issue May 23, 2018
Fixes quattor#83

Change-Id: Idf99e5fa1245e8e5b6edc56fb542377ec5548877
@jouvin
Copy link
Contributor Author

jouvin commented May 24, 2018

After more experience with Aquilon and a discussion with @urbonegi , I agree that these templates have to exist in a real configuration and that it is better to expose that they are missing.

@jouvin jouvin closed this as completed May 24, 2018
ned21 pushed a commit to ned21/aquilon that referenced this issue Mar 4, 2020
…merge/master/by_topic/shared_sa to master

* commit 'b3aee3eae3a02513cfbc7ab1657740dc6cd1f11c':
  Support for shared-service-name resources in resourcegroups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants