Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-systemd: try-restart should be skipped for units which do not allow manual start/stop #1395

Open
gombasg opened this issue Aug 26, 2019 · 0 comments
Open

ncm-systemd: try-restart should be skipped for units which do not allow manual start/stop #1395

gombasg opened this issue Aug 26, 2019 · 0 comments

Comments

@gombasg
Copy link
Contributor

gombasg commented Aug 26, 2019

If a unit has either RefuseManualStart=true or RefuseManualStop=true, then the systemctl try-restart command emitted by ncm-systemd will fail. The component should detect the presence of those options (even if these options are not coming from the Quattor-managed part of the unit definition), and should not try to restart such services.

As a workaround, allowing the profile to say a service should not be restarted even if its unit changes would also work, and could actually be useful regardless of this issue.
gombasg added a commit to gombasg/configuration-modules-core that referenced this issue Nov 14, 2019
@gombasg
ncm-systemd: Do not try to restart sevices which cannot
611cb9e 
Attempt to address issue quattor#1395, but only if the RefuseManual* directives
are defined in the profiles. If those directives are coming from unit
fragments which are not managed by Quattor, then restart is still
attempted, and the component will fail.
@gombasg gombasg mentioned this issue Nov 14, 2019
Merged
jrha pushed a commit to gombasg/configuration-modules-core that referenced this issue Dec 17, 2020
@gombasg @jrha
ncm-systemd: Do not try to restart sevices which cannot
b86d522 
Attempt to address issue quattor#1395, but only if the RefuseManual* directives
are defined in the profiles. If those directives are coming from unit
fragments which are not managed by Quattor, then restart is still
attempted, and the component will fail.
jrha pushed a commit to gombasg/configuration-modules-core that referenced this issue Apr 26, 2021
@gombasg @jrha
ncm-systemd: Do not try to restart sevices which cannot
e64b056 
Attempt to address issue quattor#1395, but only if the RefuseManual* directives
are defined in the profiles. If those directives are coming from unit
fragments which are not managed by Quattor, then restart is still
attempted, and the component will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gombasg