Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ncm-metaconfig: rsyslog kafka output action #1424

Merged
merged 3 commits into from
Dec 16, 2020
Merged

ncm-metaconfig: rsyslog kafka output action #1424

merged 3 commits into from
Dec 16, 2020

Conversation

itkovian
Copy link
Contributor

Support actions that output to Kafka.

@jrha jrha added this to the 20.2 milestone Jan 16, 2020
jrha
jrha reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@jrha jrha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Assuming the strings can all contain whitespace, would string_trimmed be a good fit for things like Topic?

@stdweird
Copy link
Member

jenkins test this please

@jrha
Copy link
Member

jrha commented Oct 12, 2020

rebased

@jrha jrha merged commit d5b44c2 into quattor:master Dec 16, 2020
@jrha jrha mentioned this pull request Dec 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha jrha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
20.12
Development

Successfully merging this pull request may close these issues.
3 participants
@itkovian @stdweird @jrha