Improve the error message when failing to lock a package #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks much better. |
|
That set contains, initially, all the packages that were declared with At the final stage (in that print) it contains only packages that had wildcards (and therefore we didn't expect to match precisely) or packages that we wanted to match and lock but failed. We only report the latter. |
|
Ok cool, in that case perhaps the error message should be something like: |
As suggested by James.
jouvin
added a commit
that referenced
this pull request
Mar 11, 2014
Improve the error message when failing to lock a package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this message is more helpful. Better wording will be appreciated.