ncm-network: nmstate enhancements #1647
Merged
+317
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmstatectl apply merges current route state config with desired state. Adding state: absent to route config for the interface will clear routes before adding the desired state instead of merge. Therefore keeping only the routes configured through the profiles.
This was referenced Jan 11, 2024
|
@ned21 thank your for review to the recent pr's I created, I thought its best just do one PR because the changes are related, especially with the testing that I've added, it requires all 3 commits. first 2 you already reviewed. hope that is ok. All changes are now in this one. @jrha please can this be looked into in your own time. |
jrha
changed the title
jrha
reviewed
Jan 25, 2024
- add a default absent rule to clear route rules entries for the table. nmstate by default will merge rules therefore won't clear if there are any old rules already present. This will make sure only rules defined by profile is present.
aka7
force-pushed
the
ncm_network_nmstate_enhancements
branch
from
bc4b03b
to
3b6aff5
Compare
- mimic bootproto settings to default to static, to match network.pm. - refactored the conditions for setting config based on bootproto. - support to configure dhcp interface. - fixed the way bonded interface is recognised - add advance testing for nmstate interface config
aka7
force-pushed
the
ncm_network_nmstate_enhancements
branch
from
3b6aff5
to
7a72ad9
Compare
stdweird
reviewed
Feb 5, 2024
StephaneGerardVUB
added a commit
to StephaneGerardVUB/configuration-modules-core
that referenced
this pull request
Feb 5, 2024
jrha
approved these changes
Feb 13, 2024
|
@jrha is there anything outstanding on this PR or can this be merged? Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following enhancements:
nmstatectlapply does not replace running config, it instead merges current state config with desired state. This is not useful when settings have been removed such as routing and policy routing and rules.state: absentwill remove config routes entry that matches the interface as next hop and therefore will only apply the routes configured in host profile profile. so following changes added.absent entry added when route for that interface. will clean all routes matching that interface when applying:
absent entry add route-rules to match any rules with the table id and clear it when applying rules.
made nmstate mimic bootproto setting of network.pm
refactored configuration settings of each interfaces type.
add more advance testing for interface configuration, bonding and valn.