ncm-network: nmstate - add additional route rule parameters #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ned21
reviewed
Jan 6, 2024
aka7
force-pushed
the
ncm_network_nmstate_rule_param
branch
from
c4b3700
to
3bf9871
Compare
|
Thanks for making the changes. I see there's now a merge commit in the branch. Our preference is for a linear history: any chance you can use rebase to bring the branch up to date with main instead of merge? |
- provide additional route rule parameters for nmstate config as defined in https://nmstate.io/devel/yaml_api.html#routes - add a default absent rule to clear route rules entries for the table. nmstate by default will merge rules therefore won't clear if there are any old rules already present. This will make sure only rules defined by profile is present.
aka7
force-pushed
the
ncm_network_nmstate_rule_param
branch
from
28c0265
to
d113bfa
Compare
ah sorry, that's my bad. wasn't meant push the merge commit out. |
|
closing PR in favor of one, #1647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide additional route rule parameters for nmstate config as defined in https://nmstate.io/devel/yaml_api.html#routes
Also add a default absent rule to clear route rules entries for the table. nmstate by default will merge rules therefore won't clear if there are any old rules already present. This will make sure only rules defined by profile is present.
Enhancement to policy based routing.
None.