ncm-download: Fixed false failure bug, added noaction support #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Automatic reply from Jenkins: Can I test this? |
| # http://eu-datagrid.web.cern.ch/eu-datagrid/license.html. | ||
| # | ||
| # THE FOLLOWING DISCLAIMER APPLIES TO ALL SOFTWARE CODE AND OTHER MATERIALS | ||
| # http://eu-datagrid.web.cern.ch/eu-datagrid/license.html. |
There was a problem hiding this comment.
replace block with # ${license-info}
There was a problem hiding this comment.
Fixed in all pan files
|
ok to test |
Fixed the problem where occasionally curl reported a failure (inspite of using the option to prevent this) which caused ncm-download to incorrectly report an error. Modernised to include --noaction support. Component already had unit tests in spite of using LC::Check::status. It turns out that LC::Check::status *does* support noaction so is test safe.
jrha
changed the title
|
Looks good for 14.8 @stdweird merge when you are happy! |
|
@stdweird, I leave it to you to decide when this should be merged. |
jrha
added a commit
that referenced
this pull request
Aug 2, 2014
ncm-download: Fixed false failure bug, added noaction support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem where occasionally curl reported a failure (inspite of
using the option to prevent this) which caused ncm-download to
incorrectly report an error.
Modernised to include --noaction support. Component already had unit
tests in spite of using LC::Check::status. It turns out that
LC::Check::status does support noaction so is test safe.