ncm-network: allow for bonding with lacp while keeping validation

[wdpypere]

When bonding with LACP is configured (mode=4), updelay and primary are not required but lacp_rate is.

[stdweird]

@wdpypere set milestone and add ncm-network prefix to the title

[hpcugentbot]

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/522/
Test PASSed.

[jrha]

LGTM, could mode be restricted? IIRC only modes 0..6 are valid.

[wdpypere]

@jrha it is updated.

[hpcugentbot]

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/527/
Test PASSed.

[Pansanel]

Are you sure that lacp_rate is required by mode=4? We are using this mode with only miimon set and it works fine. According to https://www.centos.org/docs/5/html/5.1/Deployment_Guide/s3-modules-bonding-directives.html, lacp_rate has a default value (0).

[wdpypere]

@Pansanel You are correct, I'll update the pull request.

[hpcugentbot]

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/533/
Test PASSed.

[Pansanel]

As you can read on:
https://www.kernel.org/doc/Documentation/networking/bonding.txt
primary option is only valid for active-backup mode (active-backup(1), balance-tlb (5) and balance-alb (6)). It has not to be required by other mode, and we could also check that primary is not set with other mode than 1, 5 or 6.

[wdpypere]

@Pansanel can you check again? I made primary mandatory for mode 1, 5 and 6, and made sure it is not configured for the other modes.
I also removed the updelay check as it has a default and is only needed with miimon.

[hpcugentbot]

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/538/
Test PASSed.

[Pansanel]

It is ok for me. Can I merge the PR?