-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncm-network: allow for bonding with lacp while keeping validation #420
Conversation
@wdpypere set milestone and add |
Refer to this link for build results (access rights to CI server needed): |
LGTM, could |
@jrha it is updated. |
Refer to this link for build results (access rights to CI server needed): |
Are you sure that lacp_rate is required by mode=4? We are using this mode with only miimon set and it works fine. According to https://www.centos.org/docs/5/html/5.1/Deployment_Guide/s3-modules-bonding-directives.html, lacp_rate has a default value (0). |
@Pansanel You are correct, I'll update the pull request. |
Refer to this link for build results (access rights to CI server needed): |
As you can read on: |
…a default and is only needed with miimon.
@Pansanel can you check again? I made primary mandatory for mode 1, 5 and 6, and made sure it is not configured for the other modes. |
Refer to this link for build results (access rights to CI server needed): |
It is ok for me. Can I merge the PR? |
ncm-network: allow for bonding with lacp while keeping validation
When bonding with LACP is configured (mode=4), updelay and primary are not required but lacp_rate is.