ncm-ceph: various additions #520
Conversation
|
fixes #419 |
| @@ -318,14 +321,24 @@ type ceph_cluster = { | |||
| 'crushmap' ? ceph_crushmap | |||
| }; | |||
|
|
|||
| @documentation{ | |||
| Decentralized config feature: | |||
| For use with dedicated pan code that builds the cluster info from remote templates.. | |||
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -89,10 +89,12 @@ sub inject_realtime { | |||
| if (!($param ~~ @NONINJECT)) { # Requires Perl > 5.10 ! | |||
| @cmd = ('tell',"*.$host",'injectargs','--'); | |||
| my $keyvalue = "--$param=$changes->{$param}"; | |||
| $self->info("injecting $keyvalue realtime on $host"); | |||
| $self->run_ceph_command([@cmd, $keyvalue]) or return 0; | |||
| #$self->info("injecting $keyvalue realtime on $host"); # this does not work anymore, see mailinglist | |||
|
@kwaegema minor remarks, LGTM otherwise |
|
Refer to this link for build results (access rights to CI server needed): |
|
Does this needs additional review? |
| foreach (name;cluster;clusters) { | ||
| append(names, name); | ||
| }; | ||
| if(exists(ARGV[0]['clusters'])) { |
There was a problem hiding this comment.
avoid the extra indent, do a
if(! exists(ARGV[0]['clusters'])) { return(true); };(also, set it before the names = list();
|
Refer to this link for build results (access rights to CI server needed): |
|
remarks processed |
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM |
|
LGTM |
max_add_osd_failures_per_hostoption to be flexible with osd failures