-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncm-network: Add fqdn to interface_alias type #524
Conversation
This is inserted by aquilon for any aliases with hostnames.
Refer to this link for build results (access rights to CI server needed): |
@@ -18,6 +18,7 @@ type structure_interface_alias = { | |||
"ip" ? type_ip | |||
"netmask" : type_ip | |||
"broadcast" ? type_ip | |||
"fqdn" ? string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this supposed to do/achieve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every interface has a fqdn in DNS. e.g. myhost-hb.dc1.quattor.org is an interface of myhost.dc1.quattor.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense, but how is this used? e.g. is there a component that uses this? (i'm just curious)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But perhaps it should be type_fqdn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
Currently not used directly for configuration, but it gets into various reports. |
They show up in |
retest this please |
@jrha add |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
LGTM |
ncm-network: Add fqdn to interface_alias type
This is inserted by aquilon for any aliases with hostnames.