Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-network: Add fqdn to interface_alias type #524

Merged
merged 2 commits into from
Aug 13, 2015

Conversation

jrha
Copy link
Member

@jrha jrha commented Jun 8, 2015

This is inserted by aquilon for any aliases with hostnames.

This is inserted by aquilon for any aliases with hostnames.
@jrha jrha added this to the 15.6 milestone Jun 8, 2015
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/704/
Test FAILed.

@@ -18,6 +18,7 @@ type structure_interface_alias = {
"ip" ? type_ip
"netmask" : type_ip
"broadcast" ? type_ip
"fqdn" ? string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this supposed to do/achieve?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every interface has a fqdn in DNS. e.g. myhost-hb.dc1.quattor.org is an interface of myhost.dc1.quattor.org.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, but how is this used? e.g. is there a component that uses this? (i'm just curious)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But perhaps it should be type_fqdn?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please

@gombasg
Copy link
Contributor

gombasg commented Jun 9, 2015

Currently not used directly for configuration, but it gets into various reports.

@jrha
Copy link
Member Author

jrha commented Jun 9, 2015

They show up in aq dump_dns and so can be used to configure a DNS server.

@stdweird
Copy link
Member

retest this please

@stdweird
Copy link
Member

@jrha add ncm-network: in title

@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/714/
Test PASSed (test).

@jrha jrha changed the title Add fqdn to interface_alias type ncm-network: Add fqdn to interface_alias type Jul 1, 2015
@hpcugentbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://jenkins1.ugent.be/job/NCM_Components-pull_requests/728/
Test PASSed (test).

@stdweird
Copy link
Member

stdweird commented Aug 6, 2015

LGTM

stdweird added a commit that referenced this pull request Aug 13, 2015
ncm-network: Add fqdn to interface_alias type
@stdweird stdweird merged commit dfae456 into quattor:master Aug 13, 2015
@jrha jrha deleted the network-alias-fqdn branch August 13, 2015 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants