ncm-ceph: fix user for known_hosts and fix output for destroy and restart

[kwaegema]

fixes #585 and #586

[piojo-zz]

Sorry for looking at something that is not in the diff, but whaty's the purpose of this? It looks like you only care on whether the output is empty?

[kwaegema]

($key_accept eq 'first') means: only add the ssh key blindy if it is not already there. If it is there, it will not replace it, it only does that when key_accept is 'always'

[piojo-zz]

Sorry, github isn't showing you what I meant. I meant this chunk (expand the context):

my $cmd = ['/usr/bin/ssh-keygen', '-F', $host];
my $output = $self->run_command_as_ceph($cmd);
# Count the lines of the output
my $lines = $output =~ tr/\n//;
if (!$lines) {

Why do you need to count lines at all? It looks to me like you're doing something if there is output and something if there isn't.

[kwaegema]

It needs to trim the newlines, because of the behaviour of ssh-keygen:

[kwaegema@daenerys ~]$ bla=`ssh-keygen -F gastlyf.ugent.be`
[kwaegema@daenerys ~]$ echo $bla

[kwaegema@daenerys ~]$ 

[stdweird]

@kwaegema minor remark and update branch

[stdweird]

rebase instead of update branch

[kwaegema]

done

[kwaegema]

@stdweird rebased again

[jrha]

@gvasilak can you have a look over this?

[jrha]

Also @GRyall...