Test::Quattor: set $Test::Quattor::NoAction default to 1 #160
Conversation
| @@ -1206,10 +1206,29 @@ sub remove_any | |||
| my $filter = sub { | |||
| my $fs = shift; | |||
| my $pattern = '^'.$path.'/'; | |||
| my @del; | |||
| foreach my $p (grep {m/$pattern/} sort keys %$fs) { | |||
There was a problem hiding this comment.
I have nothing against one letter variable in loops but what $p stands for... It would be good to have something a little clearer...
| push(@del, $path); | ||
|
|
||
| foreach my $p (@del) { | ||
| # look for any hardlink that has $p as target |
There was a problem hiding this comment.
You should better explain what you intend to do here... I found it hard to understand! If I did, you want to ensure that when you delete a hardlink target, one of the hardlinks to this path has its contents updated to the contents of the path about to be deleted (the path expressing in fact the file type in the mocked context).
|
|
||
| $filename = sane_path($filename); | ||
| my $dfn = $desired_file_contents{$filename}; | ||
| if (defined($dfn)) { |
There was a problem hiding this comment.
Why dfn acronym for a desired file contents? Shoud be dfc, shouldn't it?
|
|
||
| =pod | ||
| Pick up original content (for C<<CAF::FileWriter->close>>) and source |
|
@jouvin i tried to improve the explanation a bit |
|
@stdweird have you done it already or do you plan to do it? |
|
@jouvin for got to push force, should be ok now |
|
@stdweird is this required to be in the next release of the build tools? |
|
@jrha yes. this PR contains the required cleanup and fixes for the new new FileWriter. |
|
Thanks, could you respond to @jouvin's comment? |
|
@jouvin are you happy with this now? |
|
Ok, no worries. |
…e at least one working hardlink
…ginal to force usage of unmocked CAF::Path code in ProfileCache
…ed templates as workaround for issue quattor#143
|
@jrha that simpler than i tought. should be ok now |
|
Thanks! @jouvin, can you update your review? |
this removes the
set_caf_file_close_difffunction. it is now default and "just works".Replaces #150, fixes #139.