FileWriter: Handle default permissions #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdweird
force-pushed
the
writer_def_perms
branch
from
12e79a6
to
2fc79e6
Compare
… the default file permissions and create parent directory with CAF::Path
stdweird
force-pushed
the
writer_def_perms
branch
from
2fc79e6
to
7395d81
Compare
|
@jrha @jouvin @ned21 summary: we need this PR to fix the issue, and #244 and new build tools with quattor/maven-tools#160 for the unittests. i'm testing the new build-tools, but expect PRs with minor changes in most repos. if i see common pattern, i'll make a PR with even newer build-tools to smoothen the transition and get 17.3 out. |
ned21
reviewed
Apr 14, 2017
src/main/perl/FileWriter.pm
Outdated
| # Pass NoAction here, as it keeps track of the NoAction value during initialisation and/or keeps_state | ||
| my $cafpath = CAF::Path::mkcafpath(log => *$self->{LOG}, NoAction => $options->{noaction}); | ||
| # only create the directory if it didn't exist yet | ||
| # if not, this would for the directory mode on existing directories |
There was a problem hiding this comment.
Sorry I don't understand this comment. Did you mean "if not, this would change the directory mode on existing directories"?
stdweird
force-pushed
the
writer_def_perms
branch
from
8163420
to
3fa7e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
This PR does not require #244, but a lot of unittests will fail if it is not merged first