Rename Test::Quattor::TextRender::Base mock method to mock_textrender #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re descriptive mock_textrender
|
Refer to this link for build results (access rights to CI server needed): |
|
should never have made it in master like this, even i start to find the name confusing 😄 |
So is this safe to merge? |
|
@ned21 yes, only after the release is published and build tools bumped in the pom, some tests will fail, and this is how to fix them. |
ned21
added a commit
that referenced
this pull request
Jul 16, 2015
Rename Test::Quattor::TextRender::Base mock method to mock_textrender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unittest will fail, but fix should be as simple as changing
use Test::Quattor::TextRender::Base; mock();to
use Test::Quattor::TextRender::Base; mock_textrender();